Bug 139782 - [WinCairo] Compile error in code for creating GL context.
Summary: [WinCairo] Compile error in code for creating GL context.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-18 11:01 PST by peavo
Modified: 2014-12-19 11:43 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2014-12-18 11:07 PST, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-12-18 11:01:11 PST 
The GLContext::createContextForWindow method has changed return type to std::unique_ptr.
Comment 1 peavo 2014-12-18 11:07:15 PST 
Created attachment 243503 [details]
Patch
Comment 2 Alex Christensen 2014-12-18 18:28:37 PST 
Comment on attachment 243503 [details]
Patch

Thanks for keeping up with this.  I'm working on some other urgent things right now, but I'll try to get a WinCairo build bot up soon so everybody can see and fix these simple compile problems.
Comment 3 WebKit Commit Bot 2014-12-18 19:04:59 PST 
Comment on attachment 243503 [details]
Patch

Clearing flags on attachment: 243503

Committed r177558: <http://trac.webkit.org/changeset/177558>
Comment 4 WebKit Commit Bot 2014-12-18 19:05:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 peavo 2014-12-19 11:43:25 PST 
(In reply to comment #2)
> Comment on attachment 243503 [details]
> Patch
> 
> Thanks for keeping up with this.  I'm working on some other urgent things
> right now, but I'll try to get a WinCairo build bot up soon so everybody can
> see and fix these simple compile problems.

That would be very nice, thanks for reviewing :)