Add decoration icon in the search field in the minibrowser.
Created attachment 243494 [details] Patch
(In reply to comment #1) > Created attachment 243494 [details] > Patch Hi all, request to review.
I tested, it works fine for me. It seems a little bit strange for me that search_icon is handled in a different way as other parts of the search toolbar, but I'm not EFL UI expert, so I let the technical review for others.
Hi , It is implemented such that it supports changes to search icon as per the theme. Also to reuse the existing icon. Please let me know if there are any other comments?
Comment on attachment 243494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243494&action=review > Tools/MiniBrowser/efl/main.c:417 > + edje_obj = edje_object_add(window->elm_window); > + edje_object_file_set(edje_obj, DEFAULT_THEME_DIR "/default.edj", "webkit/widget/search/results_decoration"); > + icon = edje_object_part_object_get(edje_obj, "decoration"); Are there any reason you want to use edje object of webkit theme instead of standard elm_icon such as "edit-find" ?
I cannot find a icon suitable for this purpose in the already existing elm_icon's. Since the suitable icon is only available in webkit theme i am re-using the same.
(In reply to comment #6) > I cannot find a icon suitable for this purpose in the already existing > elm_icon's. Since the suitable icon is only available in webkit theme i am > re-using the same. Please check "edit-find". It is introduced since 1.13. I think that we can use it because ewebkit is under development on EFL 1.13 since r180697.
Created attachment 253178 [details] Patch
Sorry for the delay. I am uploading a patch using the "edit-find" icon available in EFL 1.13. Please have a look.
Comment on attachment 253178 [details] Patch LGTM. r=me.
Comment on attachment 253178 [details] Patch Clearing flags on attachment: 253178 Committed r184432: <http://trac.webkit.org/changeset/184432>
All reviewed patches have been landed. Closing bug.