WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139771
[GTK] [EFL] Enable per_test_timeout
https://bugs.webkit.org/show_bug.cgi?id=139771
Summary
[GTK] [EFL] Enable per_test_timeout
Carlos Alberto Lopez Perez
Reported
2014-12-18 05:06:55 PST
Following the discussion on
https://bugs.webkit.org/show_bug.cgi?id=139671
and
https://bugs.webkit.org/show_bug.cgi?id=139734
supports_per_test_timeout() should be enabled in order to pass to WKTR the --timeout parameter: Tools/Scripts/webkitpy/port/driver.py: if self._port.supports_per_test_timeout(): Tools/Scripts/webkitpy/port/driver.py: command += "'--timeout'%s" % driver_input.timeout This is needed to make WKTR use either the default port timeout, or the user supplied timeout via "Tools/Scripts/run-webkit-tests --time-out-ms=...". Otherwise WTR will use the default (30 seconds after
r177363
). GTK and EFL ports are not enabling it, so enable it.
Attachments
Patch
(2.07 KB, patch)
2014-12-18 05:27 PST
,
Carlos Alberto Lopez Perez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2014-12-18 05:27:59 PST
Created
attachment 243493
[details]
Patch
Csaba Osztrogonác
Comment 2
2014-12-18 05:29:44 PST
Comment on
attachment 243493
[details]
Patch rs=me
Carlos Alberto Lopez Perez
Comment 3
2014-12-18 05:32:44 PST
Comment on
attachment 243493
[details]
Patch Clearing flags on attachment: 243493 Committed
r177493
: <
http://trac.webkit.org/changeset/177493
>
Carlos Alberto Lopez Perez
Comment 4
2014-12-18 05:32:52 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug