Bug 139746 - LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
Summary: LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad iOS 8.1
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-17 13:43 PST by Daniel Bates
Modified: 2015-02-05 14:46 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.97 KB, patch)
2015-02-05 13:58 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-12-17 13:43:47 PST 
Sometimes run-webkit-tests will time out all tests because LayoutTestRelay did not install DumpRenderTree.app/WebKitTestRunnerApp.app in the iOS Simulator instance it launched.

Most recently this happened when I am ran run-webkit-tests using a command line of the form:
Tools/Scripts/run-webkit-tests --ios-sim --runtime com.apple.CoreSimulator.SimRuntime.iOS-[...] --device-type com.apple.CoreSimulator.SimDeviceType.iPhone-5s --no-sample-on-timeout --add-platform-exceptions --no-retry-failures --results-directory layout-test-results-rebase -2 LayoutTests/css2.1
Comment 1 Radar WebKit Bug Importer 2014-12-17 13:44:35 PST 
<rdar://problem/19283658>
Comment 2 Radar WebKit Bug Importer 2014-12-17 13:44:43 PST 
<rdar://problem/19283661>
Comment 3 Daniel Bates 2014-12-17 13:51:20 PST 
(In reply to comment #2)
> <rdar://problem/19283661>

Disregard this comment.
Comment 4 Daniel Bates 2015-02-05 13:58:14 PST 
Created attachment 246127 [details]
Patch
Comment 5 Alexey Proskuryakov 2015-02-05 14:26:24 PST 
Comment on attachment 246127 [details]
Patch

Nice!
Comment 6 Daniel Bates 2015-02-05 14:46:32 PST 
Comment on attachment 246127 [details]
Patch

Clearing flags on attachment: 246127

Committed r179712: <http://trac.webkit.org/changeset/179712>
Comment 7 Daniel Bates 2015-02-05 14:46:36 PST 
All reviewed patches have been landed.  Closing bug.