Bug 139739 - [iOS] Define button and action should respect profile settings.
Summary: [iOS] Define button and action should respect profile settings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified iOS 8.1
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-17 12:11 PST by Enrica Casucci
Modified: 2014-12-17 13:56 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2014-12-17 12:16 PST, Enrica Casucci 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-12-17 12:11:28 PST 
The define button and action should only be available if not explicitly disabled via profile.
Comment 1 Enrica Casucci 2014-12-17 12:15:10 PST 
rdar://problem/15461887
Comment 2 Enrica Casucci 2014-12-17 12:16:53 PST 
Created attachment 243449 [details]
Patch
Comment 3 WebKit Commit Bot 2014-12-17 12:18:50 PST 
Attachment 243449 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:51:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1342:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Joseph Pecoraro 2014-12-17 13:46:56 PST 
Comment on attachment 243449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243449&action=review

r=me

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:52
> +#import <ManagedConfiguration/MCProfileConnection.h>
> +#import <ManagedConfiguration/MCFeatures.h>

Nit: `sort` which you already noticed.

Are these SPI? In order for this to build with the public SDK do you have to do something special? dbates has been doing something like that, so there may be something you have to do here, or maybe not.
Comment 5 Enrica Casucci 2014-12-17 13:56:04 PST 
Committed revision 177463.