Bug 139731 - Purge PassRefPtr from Frame.
Summary: Purge PassRefPtr from Frame.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-17 09:22 PST by Andreas Kling
Modified: 2014-12-17 11:38 PST (History)
3 users (show)

See Also:

Attachments
Patch (15.17 KB, patch)
2014-12-17 09:25 PST, Andreas Kling 		andersca: review+
Details | Formatted Diff | Diff
Patch for landing (15.19 KB, patch)
2014-12-17 09:36 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-12-17 09:22:27 PST 
Yep.
Comment 1 Andreas Kling 2014-12-17 09:25:11 PST 
Created attachment 243438 [details]
Patch
Comment 2 Anders Carlsson 2014-12-17 09:27:51 PST 
Comment on attachment 243438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243438&action=review

> Source/WebCore/page/Frame.cpp:210
>      ASSERT(page);
>      ASSERT(client);

Looks like these would be good candidates for turning into references.

> Source/WebKit/mac/WebView/WebFrame.mm:324
> +    Ref<Frame> coreFrame(Frame::create(page, ownerElement, new WebFrameLoaderClient(frame)));

auto coreFrame =

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:126
> +    Ref<Frame> coreFrame(Frame::create(page->corePage(), ownerElement, frame->m_frameLoaderClient.get()));

auto coreFrame =
Comment 3 Andreas Kling 2014-12-17 09:36:43 PST 
Created attachment 243439 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2014-12-17 10:22:02 PST 
The commit-queue encountered the following flaky tests while processing attachment 243439 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2014-12-17 10:22:06 PST 
The commit-queue encountered the following flaky tests while processing attachment 243439 [details]:

The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2014-12-17 11:02:49 PST 
The commit-queue encountered the following flaky tests while processing attachment 243439 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2014-12-17 11:02:52 PST 
The commit-queue encountered the following flaky tests while processing attachment 243439 [details]:

The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2014-12-17 11:38:35 PST 
Comment on attachment 243439 [details]
Patch for landing

Clearing flags on attachment: 243439

Committed r177450: <http://trac.webkit.org/changeset/177450>
Comment 9 WebKit Commit Bot 2014-12-17 11:38:38 PST 
All reviewed patches have been landed.  Closing bug.