Bug 139728 - [GTK] Allow to build with ENABLE_NETWORK_CACHE
Summary: [GTK] Allow to build with ENABLE_NETWORK_CACHE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-12-17 06:04 PST by Carlos Garcia Campos
Modified: 2014-12-18 06:41 PST (History)
4 users (show)

See Also:

Attachments
Patch (12.71 KB, patch)
2014-12-17 06:08 PST, Carlos Garcia Campos 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-12-17 06:04:02 PST 
Just make it build for now
Comment 1 Carlos Garcia Campos 2014-12-17 06:08:17 PST 
Created attachment 243434 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-12-17 06:08:59 PST 
Comment on attachment 243434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243434&action=review

> Source/WebKit2/config.h:98
> +#define ENABLE_NETWORK_CACHE 1

Enabled this just for EWS, I'll disable it again before landing.
Comment 3 WebKit Commit Bot 2014-12-17 06:09:16 PST 
Attachment 243434 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageSoup.cpp:108:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageSoup.cpp:115:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2014-12-18 06:09:08 PST 
Comment on attachment 243434 [details]
Patch

r=me
Comment 5 Antti Koivisto 2014-12-18 06:09:56 PST 
Note that the feature is work-in-progress so build breakages with it enabled are likely.
Comment 6 Carlos Garcia Campos 2014-12-18 06:41:56 PST 
Committed r177495: <http://trac.webkit.org/changeset/177495>