Bug 139718 - TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
Summary: TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-16 18:49 PST by Sam Weinig
Modified: 2015-07-18 11:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch (107.80 KB, patch)
2014-12-16 18:52 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (107.25 KB, patch)
2014-12-16 19:03 PST, Sam Weinig 		mrowe: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-12-16 18:49:07 PST 
TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
Comment 1 Sam Weinig 2014-12-16 18:52:19 PST 
Created attachment 243422 [details]
Patch
Comment 2 Mark Rowe (bdash) 2014-12-16 19:03:23 PST 
Comment on attachment 243422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243422&action=review

> Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:30
> +// FIXME: This should not be built on iOS. Instead we should TestWebKitAPI.app.

I think you're missing a word between "should" and "TestWebKitAPI.app".

> Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:34
> +
> +LD_RUNPATH_SEARCH_PATHS = "@loader_path/.";

I don't see why this change would require that this be added if it wasn't already needed.

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:308
> +		7CCE7E8A1A41144E00447C4C /* CopyFiles */ = {
> +			isa = PBXCopyFilesBuildPhase;
> +			buildActionMask = 2147483647;
> +			dstPath = "include/$(PRODUCT_NAME)";
> +			dstSubfolderSpec = 16;
> +			files = (
> +			);
> +			runOnlyForDeploymentPostprocessing = 0;
> +		};

This Copy Files phase doesn't seem necessary.
Comment 3 Sam Weinig 2014-12-16 19:03:41 PST 
Created attachment 243423 [details]
Patch
Comment 4 Mark Rowe (bdash) 2014-12-16 19:04:39 PST 
Comment on attachment 243423 [details]
Patch

One of my comments from the earlier patch still applies.
Comment 5 Sam Weinig 2014-12-16 20:01:57 PST 
Fixed in r177434.
Comment 6 mitz 2015-07-17 19:56:28 PDT 
Was there any follow-up to this? Is the static library used for anything other than linking the TestWebKitAPI executable? I see that people have kept adding tests directly to that target. Does that mean that those tests don’t run in iOS?
Comment 7 Sam Weinig 2015-07-18 11:33:48 PDT 
(In reply to comment #6)
> Was there any follow-up to this? Is the static library used for anything
> other than linking the TestWebKitAPI executable? I see that people have kept
> adding tests directly to that target. Does that mean that those tests don’t
> run in iOS?

No follow up yet.  The plan was to add a .app for iOS device. I need to check with Simon if that is still necessary.