Bug 139718 – TestWebKitAPI should use a static lib to support both Mac and iOS cleanly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

TestWebKitAPI should use a static lib to support both Mac and iOS cleanly

[Sam Weinig]

Created attachment 243422 [details]
Patch

[Mark Rowe (bdash)]

Comment on attachment 243422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243422&action=review

> Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:30
> +// FIXME: This should not be built on iOS. Instead we should TestWebKitAPI.app.

I think you're missing a word between "should" and "TestWebKitAPI.app".

> Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:34
> +
> +LD_RUNPATH_SEARCH_PATHS = "@loader_path/.";

I don't see why this change would require that this be added if it wasn't already needed.

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:308
> +		7CCE7E8A1A41144E00447C4C /* CopyFiles */ = {
> +			isa = PBXCopyFilesBuildPhase;
> +			buildActionMask = 2147483647;
> +			dstPath = "include/$(PRODUCT_NAME)";
> +			dstSubfolderSpec = 16;
> +			files = (
> +			);
> +			runOnlyForDeploymentPostprocessing = 0;
> +		};

This Copy Files phase doesn't seem necessary.

[Sam Weinig]

Created attachment 243423 [details]
Patch

[Mark Rowe (bdash)]

Comment on attachment 243423 [details]
Patch

One of my comments from the earlier patch still applies.

[Sam Weinig]

Fixed in r177434.

Was there any follow-up to this? Is the static library used for anything other than linking the TestWebKitAPI executable? I see that people have kept adding tests directly to that target. Does that mean that those tests don’t run in iOS?

[Sam Weinig]

(In reply to comment #6)
> Was there any follow-up to this? Is the static library used for anything
> other than linking the TestWebKitAPI executable? I see that people have kept
> adding tests directly to that target. Does that mean that those tests don’t
> run in iOS?

No follow up yet.  The plan was to add a .app for iOS device. I need to check with Simon if that is still necessary.