WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139714
Regression(
r163928
): Animated images are not resumed on window resizing
https://bugs.webkit.org/show_bug.cgi?id=139714
Summary
Regression(r163928): Animated images are not resumed on window resizing
Chris Dumez
Reported
2014-12-16 17:29:46 PST
After
r163928
, animated images are not resumed if they become visible after resizing the window. Radar: <
rdar://problem/18855285
>
Attachments
Patch
(5.09 KB, patch)
2014-12-16 17:38 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(5.16 KB, patch)
2014-12-16 17:39 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-mountainlion
(560.93 KB, application/zip)
2014-12-16 18:11 PST
,
Build Bot
no flags
Details
Patch
(6.45 KB, patch)
2015-01-05 10:00 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(9.31 KB, patch)
2015-01-05 11:55 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews103 for mac-mountainlion
(509.34 KB, application/zip)
2015-01-05 12:42 PST
,
Build Bot
no flags
Details
Patch
(9.30 KB, patch)
2015-01-05 12:46 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2014-12-16 17:38:26 PST
Created
attachment 243410
[details]
Patch
Chris Dumez
Comment 2
2014-12-16 17:39:50 PST
Created
attachment 243411
[details]
Patch
Build Bot
Comment 3
2014-12-16 18:11:36 PST
Comment on
attachment 243411
[details]
Patch
Attachment 243411
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/5125808679026688
New failing tests: fast/images/animated-gif-window-resizing.html
Build Bot
Comment 4
2014-12-16 18:11:40 PST
Created
attachment 243416
[details]
Archive of layout-test-results from ews101 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Chris Dumez
Comment 5
2015-01-05 10:00:28 PST
Created
attachment 243980
[details]
Patch
Darin Adler
Comment 6
2015-01-05 10:08:02 PST
Comment on
attachment 243980
[details]
Patch Is this really the only bottleneck we missed? What about zooming, for example? It’s not entirely clear why this is the one place to call this.
Chris Dumez
Comment 7
2015-01-05 10:28:22 PST
(In reply to
comment #6
)
> Comment on
attachment 243980
[details]
> Patch > > Is this really the only bottleneck we missed? What about zooming, for > example? It’s not entirely clear why this is the one place to call this.
Doesn't zooming update the FrameRect? I assumed so. I'll check.
Chris Dumez
Comment 8
2015-01-05 11:55:15 PST
Created
attachment 243984
[details]
Patch
Chris Dumez
Comment 9
2015-01-05 11:56:10 PST
(In reply to
comment #6
)
> Comment on
attachment 243980
[details]
> Patch > > Is this really the only bottleneck we missed? What about zooming, for > example? It’s not entirely clear why this is the one place to call this.
I am unable to reproduce the issue when zooming in / out. I added a layout test to cover this as well.
Build Bot
Comment 10
2015-01-05 12:42:38 PST
Comment on
attachment 243984
[details]
Patch
Attachment 243984
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/5328102712410112
New failing tests: fast/images/animated-gif-zooming.html
Build Bot
Comment 11
2015-01-05 12:42:42 PST
Created
attachment 243989
[details]
Archive of layout-test-results from ews103 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Chris Dumez
Comment 12
2015-01-05 12:46:45 PST
Created
attachment 243992
[details]
Patch
WebKit Commit Bot
Comment 13
2015-01-05 13:44:33 PST
Comment on
attachment 243992
[details]
Patch Clearing flags on attachment: 243992 Committed
r177927
: <
http://trac.webkit.org/changeset/177927
>
WebKit Commit Bot
Comment 14
2015-01-05 13:44:40 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 15
2015-01-06 10:56:30 PST
Comment on
attachment 243992
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=243992&action=review
> Source/WebCore/page/FrameView.cpp:463 > + resumeVisibleImageAnimationsIncludingSubframes();
I'm concerned that we're adding calls to this in seemingly arbitrary places. Can we have a bottleneck that captures the notion of what underlying conditions change that require this to be called?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug