Bug 139714 – Regression(r163928): Animated images are not resumed on window resizing

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Chris Dumez]

After r163928, animated images are not resumed if they become visible after resizing the window.

Radar: <rdar://problem/18855285>

[Chris Dumez]

Created attachment 243410 [details]
Patch

[Chris Dumez]

Created attachment 243411 [details]
Patch

[Build Bot]

Comment on attachment 243411 [details]
Patch

Attachment 243411 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5125808679026688

New failing tests:
fast/images/animated-gif-window-resizing.html

[Build Bot]

Created attachment 243416 [details]
Archive of layout-test-results from ews101 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Chris Dumez]

Created attachment 243980 [details]
Patch

[Darin Adler]

Comment on attachment 243980 [details]
Patch

Is this really the only bottleneck we missed? What about zooming, for example? It’s not entirely clear why this is the one place to call this.

[Chris Dumez]

(In reply to comment #6)
> Comment on attachment 243980 [details]
> Patch
> 
> Is this really the only bottleneck we missed? What about zooming, for
> example? It’s not entirely clear why this is the one place to call this.

Doesn't zooming update the FrameRect? I assumed so. I'll check.

[Chris Dumez]

Created attachment 243984 [details]
Patch

[Chris Dumez]

(In reply to comment #6)
> Comment on attachment 243980 [details]
> Patch
> 
> Is this really the only bottleneck we missed? What about zooming, for
> example? It’s not entirely clear why this is the one place to call this.

I am unable to reproduce the issue when zooming in / out. I added a layout test to cover this as well.

[Build Bot]

Comment on attachment 243984 [details]
Patch

Attachment 243984 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5328102712410112

New failing tests:
fast/images/animated-gif-zooming.html

[Build Bot]

Created attachment 243989 [details]
Archive of layout-test-results from ews103 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Chris Dumez]

Created attachment 243992 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 243992 [details]
Patch

Clearing flags on attachment: 243992

Committed r177927: <http://trac.webkit.org/changeset/177927>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

Comment on attachment 243992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243992&action=review

> Source/WebCore/page/FrameView.cpp:463
> +    resumeVisibleImageAnimationsIncludingSubframes();

I'm concerned that we're adding calls to this in seemingly arbitrary places. Can we have a bottleneck that captures the notion of what underlying conditions change that require this to be called?