Bug 139711 - REGRESSION: Preview popovers obscure the link, look wrong
Summary: REGRESSION: Preview popovers obscure the link, look wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-16 16:10 PST by Beth Dakin
Modified: 2014-12-16 16:33 PST (History)
6 users (show)

See Also:


Attachments
Patch (9.01 KB, patch)
2014-12-16 16:14 PST, Beth Dakin
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-12-16 16:10:05 PST
Preview popovers are obscurring the link. This is a regression from adoping immediate actions.

rdar://problem/19271854
Comment 1 Beth Dakin 2014-12-16 16:14:13 PST
Created attachment 243403 [details]
Patch
Comment 2 Tim Horton 2014-12-16 16:15:22 PST
Comment on attachment 243403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243403&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:422
> +    NSPopoverAnimationController *popoverController = [NSPopoverAnimationController popoverAnimationControllerWithPopover:_previewPopover.get()];

Do you need a respondsToSelector here?
Comment 3 Beth Dakin 2014-12-16 16:33:48 PST
http://trac.webkit.org/changeset/177409 Thanks!