Bug 139699 - Add a progress indicator to the preview popover
Summary: Add a progress indicator to the preview popover
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Conrad Shultz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-16 13:15 PST by Conrad Shultz
Modified: 2014-12-16 15:15 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.58 KB, patch)
2014-12-16 13:18 PST, Conrad Shultz 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Shultz 2014-12-16 13:15:28 PST 
Add a progress indicator to the preview popover.
Comment 1 Conrad Shultz 2014-12-16 13:16:05 PST 
<rdar://problem/19266297>
Comment 2 Conrad Shultz 2014-12-16 13:18:01 PST 
Created attachment 243383 [details]
Patch
Comment 3 Tim Horton 2014-12-16 13:22:55 PST 
Comment on attachment 243383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243383&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:135
> +- (void)_setPreviewLoading:(BOOL)loading;

I somewhat wish these had more specific names, but at this point you're just following the past.
Comment 4 Conrad Shultz 2014-12-16 15:15:02 PST 
Committed: http://trac.webkit.org/changeset/177402