Bug 139697 - Log which ActiveDOMObject(s) can't be suspended for PageCache.
Summary: Log which ActiveDOMObject(s) can't be suspended for PageCache.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-16 13:07 PST by Andreas Kling
Modified: 2015-01-09 16:43 PST (History)
2 users (show)

See Also:

Attachments
Patch (22.47 KB, patch)
2014-12-16 13:09 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (23.25 KB, patch)
2015-01-09 13:03 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-12-16 13:07:46 PST 
When we're trying to put a page into PageCache, we should log which kinds of ActiveDOMObjects failed to suspend, causing us to opt out of PageCache.
Comment 1 Andreas Kling 2014-12-16 13:09:56 PST 
Created attachment 243381 [details]
Patch
Comment 2 Chris Dumez 2014-12-16 13:47:52 PST 
Comment on attachment 243381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243381&action=review

doesn't build?

> Source/WebCore/dom/ScriptExecutionContext.cpp:199
> +                unsuspendableObjects->append(activeDOMObject);

else
  break;
Comment 3 Andreas Kling 2015-01-09 13:03:15 PST 
Created attachment 244366 [details]
Patch
Comment 4 Chris Dumez 2015-01-09 15:44:24 PST 
Comment on attachment 244366 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2015-01-09 16:43:54 PST 
Comment on attachment 244366 [details]
Patch

Clearing flags on attachment: 244366

Committed r178223: <http://trac.webkit.org/changeset/178223>
Comment 6 WebKit Commit Bot 2015-01-09 16:43:59 PST 
All reviewed patches have been landed.  Closing bug.