Bug 139693 - Get rid of PassRefPtr inside StorageManager
Summary: Get rid of PassRefPtr inside StorageManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-16 12:26 PST by Anders Carlsson
Modified: 2014-12-16 15:25 PST (History)
1 user (show)

See Also:

Attachments
Patch (11.25 KB, patch)
2014-12-16 12:27 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-12-16 12:26:09 PST 
Get rid of PassRefPtr inside StorageManager
Comment 1 Anders Carlsson 2014-12-16 12:27:08 PST 
Created attachment 243376 [details]
Patch
Comment 2 Andreas Kling 2014-12-16 12:33:23 PST 
Comment on attachment 243376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243376&action=review

r=me but

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:49
> +    static RefPtr<StorageArea> create(LocalStorageNamespace*, RefPtr<SecurityOrigin>&&, unsigned quotaInBytes);

This should return Ref.

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:57
> +    RefPtr<StorageArea> clone() const;

Ditto.

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:120
> +    RefPtr<StorageArea> getOrCreateStorageArea(RefPtr<SecurityOrigin>&& securityOrigin)

Ditto.

> Source/WebKit2/UIProcess/Storage/StorageManager.h:50
> +    static RefPtr<StorageManager> create(const String& localStorageDirectory);

Ditto.
Comment 3 Anders Carlsson 2014-12-16 12:35:59 PST 
Committed r177384: <http://trac.webkit.org/changeset/177384>
Comment 4 Chris Dumez 2014-12-16 15:09:53 PST 
The patch that landed still uses RefPtr instead of Ref?
Comment 5 Anders Carlsson 2014-12-16 15:25:50 PST 
(In reply to comment #4)
> The patch that landed still uses RefPtr instead of Ref?

I fixed it in a couple of followup patches.