WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139693
Get rid of PassRefPtr inside StorageManager
https://bugs.webkit.org/show_bug.cgi?id=139693
Summary
Get rid of PassRefPtr inside StorageManager
Anders Carlsson
Reported
2014-12-16 12:26:09 PST
Get rid of PassRefPtr inside StorageManager
Attachments
Patch
(11.25 KB, patch)
2014-12-16 12:27 PST
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-12-16 12:27:08 PST
Created
attachment 243376
[details]
Patch
Andreas Kling
Comment 2
2014-12-16 12:33:23 PST
Comment on
attachment 243376
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=243376&action=review
r=me but
> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:49 > + static RefPtr<StorageArea> create(LocalStorageNamespace*, RefPtr<SecurityOrigin>&&, unsigned quotaInBytes);
This should return Ref.
> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:57 > + RefPtr<StorageArea> clone() const;
Ditto.
> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:120 > + RefPtr<StorageArea> getOrCreateStorageArea(RefPtr<SecurityOrigin>&& securityOrigin)
Ditto.
> Source/WebKit2/UIProcess/Storage/StorageManager.h:50 > + static RefPtr<StorageManager> create(const String& localStorageDirectory);
Ditto.
Anders Carlsson
Comment 3
2014-12-16 12:35:59 PST
Committed
r177384
: <
http://trac.webkit.org/changeset/177384
>
Chris Dumez
Comment 4
2014-12-16 15:09:53 PST
The patch that landed still uses RefPtr instead of Ref?
Anders Carlsson
Comment 5
2014-12-16 15:25:50 PST
(In reply to
comment #4
)
> The patch that landed still uses RefPtr instead of Ref?
I fixed it in a couple of followup patches.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug