Bug 139688 – [iOS] Make it possible to toggle FeatureCounter support at runtime

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Chris Dumez]

Make it possible to toggle FeatureCounter support at runtime using a setting. Also disable FeatureCounter support when a private session is used.

Radar: <rdar://problem/19266254>

[Chris Dumez]

Created attachment 243371 [details]
Patch

Comment on attachment 243371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243371&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:49
> +@property (nonatomic, setter=_setFeatureCounterEnabled:) BOOL _featureCounterEnabled;

This new SPI needs an availability annotation such as WK_AVAILABLE(WK_TBD, WK_TBD)

[Chris Dumez]

Created attachment 243395 [details]
Patch

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 243371 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243371&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:49
> > +@property (nonatomic, setter=_setFeatureCounterEnabled:) BOOL _featureCounterEnabled;
> 
> This new SPI needs an availability annotation such as WK_AVAILABLE(WK_TBD,
> WK_TBD)

Thanks, done. I used WK_TBA as it seems to be what is used elsewhere.

[Chris Dumez]

Created attachment 243447 [details]
Patch

[Andreas Kling]

Comment on attachment 243447 [details]
Patch

r=me

[Chris Dumez]

Comment on attachment 243447 [details]
Patch

Clearing flags on attachment: 243447

Committed r177455: <http://trac.webkit.org/changeset/177455>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.