Bug 139682 - Put some common code in StorageNamespaceProvider
Summary: Put some common code in StorageNamespaceProvider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-16 10:07 PST by Anders Carlsson
Modified: 2015-05-05 14:47 PDT (History)
0 users

See Also:


Attachments
Patch (7.13 KB, patch)
2014-12-16 10:12 PST, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-12-16 10:07:04 PST
Put some common code in StorageNamespaceProvider
Comment 1 Anders Carlsson 2014-12-16 10:12:35 PST
Created attachment 243365 [details]
Patch
Comment 2 Anders Carlsson 2014-12-16 10:38:34 PST
Committed r177365: <http://trac.webkit.org/changeset/177365>
Comment 3 Joseph Pecoraro 2015-05-05 14:47:53 PDT
Comment on attachment 243365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243365&action=review

> Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:203
> -    return page->sessionStorage()->storageArea(document->securityOrigin());
> +    return m_pageAgent->page()->storageNamespaceProvider().localStorageArea(*targetFrame->document());

Looks like this makes the Inspector always return localStorage instead of sessionStorage in some cases.