WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139676
Set relayoutChildren to 'true' only if size change happens in Table
https://bugs.webkit.org/show_bug.cgi?id=139676
Summary
Set relayoutChildren to 'true' only if size change happens in Table
Roland Takacs
Reported
2014-12-16 01:57:52 PST
This patch passes 'true' value for layoutPositionedObjects() in case of size change. It helps to avoid unneccessary setChildNeedsLayout() and setPreferredLogicalWidthsDirty() calls.
Attachments
patch
(1.36 KB, patch)
2014-12-16 02:00 PST
,
Roland Takacs
ossy
: review-
ossy
: commit-queue-
Details
Formatted Diff
Diff
Added the missing changelog
(2.26 KB, patch)
2014-12-23 01:09 PST
,
Éva Balázsfalvi
no flags
Details
Formatted Diff
Diff
patch
(2.26 KB, patch)
2014-12-23 01:14 PST
,
Roland Takacs
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Roland Takacs
Comment 1
2014-12-16 02:00:26 PST
Created
attachment 243354
[details]
patch
Csaba Osztrogonác
Comment 2
2014-12-22 01:17:23 PST
Comment on
attachment 243354
[details]
patch r- due to missing changelog
Éva Balázsfalvi
Comment 3
2014-12-23 01:09:00 PST
Created
attachment 243668
[details]
Added the missing changelog
Roland Takacs
Comment 4
2014-12-23 01:14:37 PST
Created
attachment 243669
[details]
patch
Darin Adler
Comment 5
2014-12-28 10:51:22 PST
Comment on
attachment 243669
[details]
patch I guess there’s no simple way to make a test to show the performance improvement from this? Too bad; we really prefer tests for anything like this.
WebKit Commit Bot
Comment 6
2014-12-28 11:32:34 PST
Comment on
attachment 243669
[details]
patch Clearing flags on attachment: 243669 Committed
r177782
: <
http://trac.webkit.org/changeset/177782
>
WebKit Commit Bot
Comment 7
2014-12-28 11:32:39 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug