Bug 139667 – Incorrect order of arguments in initial-letter property

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Cramer]

The order of arguments in the implementation of the initial-letter property does not match the current spec (http://dev.w3.org/csswg/css-inline/#sizing-drop-initials). The first argument should be size, and the second argument should be the number of lines that the initial letter sinks. This was incorrect in earlier versions of the editor's draft, due to an error by said editor. For example,

p::first-letter { -webkit-initial-letter: 3 1 } 

should produce a pure "raised cap," the size of a 3-line drop cap but sitting on the first text baseline.

[Sylvain Galineau]

Created attachment 246350 [details]
fix.patch

Swapped the arguments in CSSParser.cpp. Updated the layout tests.

[Darin Adler]

Comment on attachment 246350 [details]
fix.patch

I think we shipped this in multiple web browser versions. Maybe we should swap the order only when removing the WebKit prefix and keep the backwards version for a while with the vendor prefix?

[Jon Lee]

(In reply to comment #2)
> Comment on attachment 246350 [details]
> fix.patch
> 
> I think we shipped this in multiple web browser versions. Maybe we should
> swap the order only when removing the WebKit prefix and keep the backwards
> version for a while with the vendor prefix?

We haven't shipped this. You might be confusing this with first-letter (see 136484).

[Sylvain Galineau]

Any additional work needed to land this patch?

[Radar WebKit Bug Importer]

<rdar://problem/21404945>

[WebKit Commit Bot]

Comment on attachment 246350 [details]
fix.patch

Clearing flags on attachment: 246350

Committed r185595: <http://trac.webkit.org/changeset/185595>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.