Bug 139657 - Separate counted and hysteresis activities in PageThrottler
Summary: Separate counted and hysteresis activities in PageThrottler
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-15 15:14 PST by Gavin Barraclough
Modified: 2014-12-15 15:19 PST (History)
1 user (show)

See Also:


Attachments
Fix (4.40 KB, patch)
2014-12-15 15:16 PST, Gavin Barraclough
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-12-15 15:14:05 PST
Currently all activities funnel into a common hysteresis mechanism, the result of which is combined with the visually idle state, the result of which in turn drives a UserActivity::Impl.

This is a first refactoring towards moving the UserActivity out to WebKit2. Use m_hysteresis only of the impulse activities (plugin evaluation, user input), and flatten the three types of activities (impulse, counted, ViewState) to all directly control a UserActivity. Switch from a UserActivity::Impl to a UserActivity since this will provide hysteresis for media activity.
Comment 1 Gavin Barraclough 2014-12-15 15:16:49 PST
Created attachment 243315 [details]
Fix
Comment 2 WebKit Commit Bot 2014-12-15 15:19:24 PST
Attachment 243315 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PageThrottler.cpp:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.