Bug 139650 - Switching src of <video> with clipping layer results in empty black square.
Summary: Switching src of <video> with clipping layer results in empty black square.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-15 11:21 PST by Jer Noble
Modified: 2015-01-26 08:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.53 KB, patch)
2014-12-15 11:24 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (6.01 KB, patch)
2014-12-15 14:11 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-12-15 11:21:05 PST 
Switching src of <video> with clipping layer results in empty black square.
Comment 1 Jer Noble 2014-12-15 11:24:46 PST 
Created attachment 243302 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-12-15 11:27:14 PST 
Comment on attachment 243302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243302&action=review

> Source/WebCore/ChangeLog:8
> +        Test: compositing/video-clip-change-src.html

Please move to compositing/video/

> LayoutTests/compositing/video-clip-change-src-expected.html:12
> +        video.addEventListener('canplaythrough', endTest);

Seems like this could give a false positive, if both ref and test end before a video frame is actually shown?
Comment 3 Jer Noble 2014-12-15 11:32:08 PST 
(In reply to comment #2)
> Comment on attachment 243302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243302&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Test: compositing/video-clip-change-src.html
> 
> Please move to compositing/video/
> 
> > LayoutTests/compositing/video-clip-change-src-expected.html:12
> > +        video.addEventListener('canplaythrough', endTest);
> 
> Seems like this could give a false positive, if both ref and test end before
> a video frame is actually shown?

It could; should we just do a pixel test here?
Comment 4 Simon Fraser (smfr) 2014-12-15 11:58:34 PST 
> It could; should we just do a pixel test here?

Can you make it so that missing video frames are reliably detected? E.g. <video style="background-color:blue">
Comment 5 Jer Noble 2014-12-15 14:11:58 PST 
Created attachment 243307 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2014-12-15 17:04:35 PST 
Comment on attachment 243307 [details]
Patch for landing

Clearing flags on attachment: 243307

Committed r177324: <http://trac.webkit.org/changeset/177324>