Bug 139636 - Change HysteresisActivity to use a lambda
Summary: Change HysteresisActivity to use a lambda
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2014-12-14 21:18 PST by Gavin Barraclough
Modified: 2014-12-15 11:37 PST (History)
0 users

See Also:

Fix (13.23 KB, patch)
2014-12-14 22:02 PST, Gavin Barraclough
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-12-14 21:18:31 PST
The current implementation provides notifications via callbacks to a delegate. Using a delegate with callbacks is limiting a number of ways. The callback names are very ambiguous, the callbacks must either be on a separate object (more boilerplate), or the callback must be public for HysteresisActivity to call them, or friends get involved. Without the boilerplate of extra delegate objects it's hard to scale use of these objects – a single object can't serve as a delegate for multiple HysteresisActivity members.
Comment 1 Gavin Barraclough 2014-12-14 22:02:52 PST
Created attachment 243282 [details]
Comment 2 Gavin Barraclough 2014-12-15 11:37:04 PST
Transmitting file data ..........
Committed revision 177295.