Bug 139623 – Web Inspector: Empty attribute added to a DOM tree outline element should not add whitespace within the tag

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

Steps to reproduce:

1. Click on a DOM element in the DOM tree with no attributes
2. <enter> to start editing
3. <enter> again to commit the edit

This adds an empty attribute to the UI, even though the attribute is never added in the backend.

If you instead add multiple spaces between steps 2 and 3, the edit is aborted and no extra space is added in the tag (presumably, this is because the backend rejected the change).

This is similar to https://bugs.webkit.org/show_bug.cgi?id=111036.

[Radar WebKit Bug Importer]

<rdar://problem/19281562>

[Devin Rousso]

Created attachment 304738 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 304738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304738&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:984
> +        if (!newText.trim().length)

if (!newText.trim())

An empty string is already a falsy value.

[Blaze Burg]

Comment on attachment 304738 [details]
Patch

r=me

[Devin Rousso]

Created attachment 304888 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 304888 [details]
Patch

Clearing flags on attachment: 304888

Committed r214141: <http://trac.webkit.org/changeset/214141>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.