Bug 139615 - Make better use of the stack when compiling selectors
Summary: Make better use of the stack when compiling selectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-12 20:13 PST by Benjamin Poulain
Modified: 2015-01-08 17:50 PST (History)
6 users (show)

See Also:

Attachments
Patch (93.62 KB, patch)
2014-12-12 20:34 PST, Benjamin Poulain 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mountainlion-wk2 (521.71 KB, application/zip)
2014-12-12 21:03 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews102 for mac-mountainlion (524.89 KB, application/zip)
2014-12-12 21:18 PST, Build Bot 		no flags Details
Patch (93.62 KB, patch)
2014-12-15 14:59 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mountainlion (513.76 KB, application/zip)
2014-12-15 15:40 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-mountainlion-wk2 (523.96 KB, application/zip)
2014-12-15 15:44 PST, Build Bot 		no flags Details
Patch (95.28 KB, patch)
2014-12-15 17:32 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-12-12 20:13:53 PST 
Make a better use of the stack when compiling selectors
Comment 1 Benjamin Poulain 2014-12-12 20:34:27 PST 
Created attachment 243243 [details]
Patch
Comment 2 Benjamin Poulain 2014-12-12 20:35:11 PST 
rdar://problem/19226482
Comment 3 Build Bot 2014-12-12 21:03:08 PST 
Comment on attachment 243243 [details]
Patch

Attachment 243243 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5001637953273856

New failing tests:
fast/selectors/not-selector-list-ending-with-never-matching-selectors.html
fast/selectors/querySelector-matches.html
Comment 4 Build Bot 2014-12-12 21:03:11 PST 
Created attachment 243245 [details]
Archive of layout-test-results from ews105 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-12-12 21:18:09 PST 
Comment on attachment 243243 [details]
Patch

Attachment 243243 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5356834969878528

New failing tests:
fast/selectors/not-selector-list-ending-with-never-matching-selectors.html
Comment 6 Build Bot 2014-12-12 21:18:12 PST 
Created attachment 243246 [details]
Archive of layout-test-results from ews102 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Benjamin Poulain 2014-12-15 14:59:35 PST 
Created attachment 243312 [details]
Patch
Comment 8 Build Bot 2014-12-15 15:40:42 PST 
Comment on attachment 243312 [details]
Patch

Attachment 243312 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4835047983022080

New failing tests:
fast/selectors/not-selector-list-ending-with-never-matching-selectors.html
Comment 9 Build Bot 2014-12-15 15:40:45 PST 
Created attachment 243321 [details]
Archive of layout-test-results from ews100 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2014-12-15 15:44:35 PST 
Comment on attachment 243312 [details]
Patch

Attachment 243312 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6370264178753536

New failing tests:
fast/selectors/not-selector-list-ending-with-never-matching-selectors.html
fast/selectors/querySelector-matches.html
Comment 11 Build Bot 2014-12-15 15:44:37 PST 
Created attachment 243322 [details]
Archive of layout-test-results from ews104 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 12 Benjamin Poulain 2014-12-15 17:32:26 PST 
Created attachment 243333 [details]
Patch
Comment 13 Benjamin Poulain 2014-12-20 16:51:00 PST 
bump?
Comment 14 Andreas Kling 2015-01-08 14:14:28 PST 
Comment on attachment 243333 [details]
Patch

r=me
Comment 15 Benjamin Poulain 2015-01-08 17:50:38 PST 
Comment on attachment 243333 [details]
Patch

Clearing flags on attachment: 243333

Committed r178150: <http://trac.webkit.org/changeset/178150>
Comment 16 Benjamin Poulain 2015-01-08 17:50:42 PST 
All reviewed patches have been landed.  Closing bug.