Bug 139600 – Split WebPageProxy::m_preventProcessSuppression to track pref/visibility separately

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Gavin Barraclough]

Previously WebPageProxy::m_preventProcessSuppression would be set if either the page was visible or it suppression was disabled by the pref.
Instead track these separately. This will make the user observability state applicable on iOS, too.

[Gavin Barraclough]

Created attachment 243223 [details]
Fix

[WebKit Commit Bot]

Attachment 243223 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebContext.cpp:198:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 243223 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=243223&action=review

r=me

> Source/WebKit2/ChangeLog:9
> +        or it suppression was disabled by the pref. Instead track these separately. This will make the

"its"

> Source/WebKit2/ChangeLog:13
> +        ::updateProccessSuppressionState continues to track the pref change (which matches it's name),

"its"

> Source/WebKit2/UIProcess/WebPageProxy.h:1586
> +    RefPtr<RefCounter::Count> m_pageIsUserObservable;
> +    RefPtr<RefCounter::Count> m_preventProcessSuppression;

I wonder if we should put "Count" at the ends of these names.

[Gavin Barraclough]

Transmitting file data ......
Committed revision 177255.