Bug 139570 - Layer borders on contentsLayers don't correctly toggle with the rest of the borders
Summary: Layer borders on contentsLayers don't correctly toggle with the rest of the b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-11 17:08 PST by Simon Fraser (smfr)
Modified: 2014-12-12 01:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.70 KB, patch)
2014-12-11 17:12 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-12-11 17:08:52 PST 
Layer borders on contentsLayers don't correctly toggle with the rest of the borders
Comment 1 Simon Fraser (smfr) 2014-12-11 17:12:47 PST 
Created attachment 243165 [details]
Patch
Comment 2 Tim Horton 2014-12-11 23:47:18 PST 
Comment on attachment 243165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243165&action=review

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:702
> +        RetainPtr<CGColorSpaceRef> colorSpace = adoptCF(CGColorSpaceCreateDeviceRGB());
> +        RetainPtr<CGColorRef> color = adoptCF(CGColorCreate(colorSpace.get(), components));

This maybe should use cachedCGColor (from Color.h)? Simplifies things a bit.
Comment 3 WebKit Commit Bot 2014-12-12 01:15:34 PST 
Comment on attachment 243165 [details]
Patch

Clearing flags on attachment: 243165

Committed r177214: <http://trac.webkit.org/changeset/177214>
Comment 4 WebKit Commit Bot 2014-12-12 01:15:38 PST 
All reviewed patches have been landed.  Closing bug.