Move storage code from WebCore to WebKit
Created attachment 243140 [details] Patch
Attachment 243140 [details] did not pass style-queue: ERROR: Source/WebKit/Storage/StorageAreaImpl.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/mac/Storage/WebStorageManager.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageThread.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageThread.cpp:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/Storage/StorageThread.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/Storage/StorageThread.cpp:92: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:44: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:93: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:172: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:197: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:373: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/Storage/StorageTrackerClient.h:25: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/Storage/StorageNamespaceImpl.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageTracker.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageNamespaceImpl.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageSyncManager.h:45: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 19 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 243808 [details] Patch
Attachment 243808 [details] did not pass style-queue: ERROR: Source/WebKit/Storage/StorageAreaImpl.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/mac/Storage/WebStorageManager.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageThread.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageThread.cpp:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/Storage/StorageThread.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/Storage/StorageThread.cpp:92: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:44: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:91: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/Storage/StorageTrackerClient.h:25: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/Storage/StorageNamespaceImpl.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageTracker.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageSyncManager.h:45: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 15 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r177813: <http://trac.webkit.org/changeset/177813>
Comment on attachment 243808 [details] Patch remove r? from landed patch