RESOLVED FIXED 139550
[iOS] Crash in WebKit::WebPageProxy::dispatchViewStateChange() tapping a link from another app while playing a video 
https://bugs.webkit.org/show_bug.cgi?id=139550
Summary [iOS] Crash in WebKit::WebPageProxy::dispatchViewStateChange() tapping a link...
Jer Noble
Reported 2014-12-11 12:31:11 PST
[iOS] Crash in WebKit::WebPageProxy::dispatchViewStateChange() tapping a link from another app while playing a video
Attachments
Patch (31.76 KB, patch)
2014-12-11 12:40 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (32.87 KB, patch)
2014-12-11 14:53 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (33.24 KB, patch)
2014-12-12 10:58 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-12-11 12:39:46 PST
<rdar://problem/18912280>
Jer Noble
Comment 2 2014-12-11 12:40:20 PST
Created attachment 243138 [details] Patch
Jer Noble
Comment 3 2014-12-11 14:53:29 PST
Created attachment 243149 [details] Patch
WebKit Commit Bot
Comment 4 2014-12-11 14:56:22 PST
Attachment 243149 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:879: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:894: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:964: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:969: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1071: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 5 2014-12-12 10:58:48 PST
Created attachment 243205 [details] Patch Fixed some errors that crept in during rebasing.
WebKit Commit Bot
Comment 6 2014-12-12 11:00:18 PST
Attachment 243205 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:879: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:894: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:966: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:972: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1074: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2014-12-16 11:20:01 PST
Comment on attachment 243205 [details] Patch Clearing flags on attachment: 243205 Committed r177375: <http://trac.webkit.org/changeset/177375>
WebKit Commit Bot
Comment 8 2014-12-16 11:20:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.