Bug 139550 - [iOS] Crash in WebKit::WebPageProxy::dispatchViewStateChange() tapping a link from another app while playing a video
Summary: [iOS] Crash in WebKit::WebPageProxy::dispatchViewStateChange() tapping a link...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-11 12:31 PST by Jer Noble
Modified: 2014-12-16 11:20 PST (History)
9 users (show)

See Also:

Attachments
Patch (31.76 KB, patch)
2014-12-11 12:40 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (32.87 KB, patch)
2014-12-11 14:53 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (33.24 KB, patch)
2014-12-12 10:58 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-12-11 12:31:11 PST 
[iOS] Crash in WebKit::WebPageProxy::dispatchViewStateChange() tapping a link from another app while playing a video
Comment 1 Jer Noble 2014-12-11 12:39:46 PST 
<rdar://problem/18912280>
Comment 2 Jer Noble 2014-12-11 12:40:20 PST 
Created attachment 243138 [details]
Patch
Comment 3 Jer Noble 2014-12-11 14:53:29 PST 
Created attachment 243149 [details]
Patch
Comment 4 WebKit Commit Bot 2014-12-11 14:56:22 PST 
Attachment 243149 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:879:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:894:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:964:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:969:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1071:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Jer Noble 2014-12-12 10:58:48 PST 
Created attachment 243205 [details]
Patch

Fixed some errors that crept in during rebasing.
Comment 6 WebKit Commit Bot 2014-12-12 11:00:18 PST 
Attachment 243205 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:879:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:894:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:966:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:972:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1074:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2014-12-16 11:20:01 PST 
Comment on attachment 243205 [details]
Patch

Clearing flags on attachment: 243205

Committed r177375: <http://trac.webkit.org/changeset/177375>
Comment 8 WebKit Commit Bot 2014-12-16 11:20:08 PST 
All reviewed patches have been landed.  Closing bug.