Bug 139546 - [Mac] Crash in -[WebVideoFullscreenHUDWindowController playing] in WK1 clients without FULLSCREEN_API enabled.
Summary: [Mac] Crash in -[WebVideoFullscreenHUDWindowController playing] in WK1 client...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-11 10:27 PST by Jer Noble
Modified: 2018-05-23 07:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.28 KB, patch)
2014-12-11 10:44 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (8.47 KB, patch)
2014-12-11 11:12 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-12-11 10:27:25 PST 
[Mac] Crash in -[WebVideoFullscreenHUDWindowController playing] in WK1 clients without FULLSCREEN_API enabled.
Comment 1 Jer Noble 2014-12-11 10:28:09 PST 
<rdar://problem/19172271>
Comment 2 Jer Noble 2014-12-11 10:44:23 PST 
Created attachment 243132 [details]
Patch
Comment 3 WebKit Commit Bot 2014-12-11 10:46:24 PST 
Attachment 243132 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm:409:  The parameter name "videoElement" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2014-12-11 11:04:49 PST 
Comment on attachment 243132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243132&action=review

> Source/WebCore/ChangeLog:8
> +        Finish the work began by r173230 and rename mediaElement -> videoElement in WebVideoFullscreenHUDWindowController.

Nit: "began"?
Comment 5 Jer Noble 2014-12-11 11:12:15 PST 
Created attachment 243134 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2014-12-11 11:18:12 PST 
Attachment 243134 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm:409:  The parameter name "videoElement" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2014-12-11 13:57:24 PST 
Comment on attachment 243134 [details]
Patch for landing

Clearing flags on attachment: 243134

Committed r177179: <http://trac.webkit.org/changeset/177179>
Comment 8 Frédéric Wang (:fredw) 2018-05-23 07:51:57 PDT 
Closing this bug since a patch landed for it.