Bug 139542 – Web Inspector: Add toggles for debugger pauses at console.assert failures

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

The debugger; statement will always pause if the inspector is open. It would be nice to have a toggle for that.

Perhaps we need two sections: one for "Debugger Pause Options" and another for "Breakpoints" ?

[Joseph Pecoraro]

I agree. We overload "Pause on All Exceptions" to mean a lot. Currently it:

  - pauses on console.assert failures
  - pauses on CSP (Content Security Policy) violations

These distinct issues could be pulled out to be their own toggles alongside a toggle for "debugger" statements.

Something else to keep in mind. DOMDebugger events still need a place to go:

  - pause on DOM events (click, touch, mouse, key, input, orientation, geolocation, ...)
  - pause on DOM errors (XHR failure, WebSQL errors, IndexedDB error)
  - pause on Promise lifetimes (rejection, resolved/fulfilled)

[Radar WebKit Bug Importer]

<rdar://problem/19281600>

[Joseph Pecoraro]

I was getting sick of pausing at assertion failures so I added a global breakpoint for Assertion Failures.

[Joseph Pecoraro]

Created attachment 291570 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 291571 [details]
[IMAGE] Pause on Assertion Failures Global Breakpoint

[Timothy Hatcher]

Comment on attachment 291570 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=291570&action=review

Cool!

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:110
>          this._allUncaughtExceptionsBreakpointTreeElement = new WebInspector.BreakpointTreeElement(WebInspector.debuggerManager.allUncaughtExceptionsBreakpoint, WebInspector.DebuggerSidebarPanel.ExceptionIconStyleClassName, WebInspector.UIString("All Uncaught Exceptions"));

This makes me wonder if we should drop "All" here. It looks funny next to "Assertion Failures" that does not have "All".

[Joseph Pecoraro]

(In reply to comment #6)
> Comment on attachment 291570 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291570&action=review
> 
> Cool!
> 
> > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:110
> >          this._allUncaughtExceptionsBreakpointTreeElement = new WebInspector.BreakpointTreeElement(WebInspector.debuggerManager.allUncaughtExceptionsBreakpoint, WebInspector.DebuggerSidebarPanel.ExceptionIconStyleClassName, WebInspector.UIString("All Uncaught Exceptions"));
> 
> This makes me wonder if we should drop "All" here. It looks funny next to
> "Assertion Failures" that does not have "All".

I agree. I'll rename it "Uncaught Exceptions" when I land.

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/207444>