Bug 139535 - [GTK] Fix Build Warning in WebKit2/UIProcess module
Summary: [GTK] Fix Build Warning in WebKit2/UIProcess module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-11 04:20 PST by Rohit
Modified: 2014-12-12 08:58 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.33 KB, patch)
2014-12-11 04:33 PST, Rohit
no flags Details | Formatted Diff | Diff
Patch (1.43 KB, patch)
2014-12-11 05:20 PST, Rohit
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rohit 2014-12-11 04:20:37 PST
Unused variable warning in WebKit2/UIProcess/API/gtk/WebKitWebView.cpp file and Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp file.


[351/405] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/WebKitWebView.cpp.o
../../Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:581:17: warning: unused parameter ‘webView’ [-Wunused-parameter]
 static gboolean webkitWebViewShowNotification(WebKitWebView* webView, WebKitNotification* webNotification)
                 ^
../../Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:605:17: warning: unused parameter ‘webView’ [-Wunused-parameter]
 static gboolean webkitWebViewCloseNotification(WebKitWebView* webView, WebKitNotification* webNotification)




../../Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:148:6: warning: unused parameter ‘modifiedSince’ [-Wunused-parameter]
 void NetworkProcess::clearDiskCache(std::chrono::system_clock::time_point modifiedSince, std::function<void ()> completionHandler)
      ^
../../Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:148:6: warning: unused parameter ‘completionHandler’ [-Wunused-parameter]
Comment 1 Rohit 2014-12-11 04:33:08 PST
Created attachment 243117 [details]
Patch
Comment 2 Rohit 2014-12-11 05:16:45 PST
NetworkProcess.cpp build warning is fixed in another bug https://bugs.webkit.org/show_bug.cgi?id=139534
Comment 3 Rohit 2014-12-11 05:20:10 PST
Created attachment 243119 [details]
Patch
Comment 4 WebKit Commit Bot 2014-12-12 08:58:37 PST
Comment on attachment 243119 [details]
Patch

Clearing flags on attachment: 243119

Committed r177224: <http://trac.webkit.org/changeset/177224>
Comment 5 WebKit Commit Bot 2014-12-12 08:58:42 PST
All reviewed patches have been landed.  Closing bug.