Bug 139522 - WK1: Add initial support for immediate actions
Summary: WK1: Add initial support for immediate actions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-10 18:44 PST by Beth Dakin
Modified: 2014-12-10 22:23 PST (History)
4 users (show)

See Also:

Attachments
Patch (17.29 KB, patch)
2014-12-10 21:47 PST, Beth Dakin 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-12-10 18:44:25 PST 
This bug tracks adding initial support for immediate actions to WK1
Comment 1 Beth Dakin 2014-12-10 21:47:33 PST 
Created attachment 243099 [details]
Patch
Comment 2 mitz 2014-12-10 21:52:46 PST 
Comment on attachment 243099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243099&action=review

> Source/WebKit/mac/WebView/WebImmediateActionController.h:41
> +- (id)initWithWebView:(WebView *)webView;

The return type should be instancetype

> Source/WebKit/mac/WebView/WebImmediateActionController.mm:45
> +- (id)initWithWebView:(WebView *)webView

(and here to match)
Comment 3 Beth Dakin 2014-12-10 22:23:43 PST 
Thank you, Dan! http://trac.webkit.org/changeset/177131