WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 139522
WK1: Add initial support for immediate actions
https://bugs.webkit.org/show_bug.cgi?id=139522
Summary
WK1: Add initial support for immediate actions
Beth Dakin
Reported
2014-12-10 18:44:25 PST
This bug tracks adding initial support for immediate actions to WK1
Attachments
Patch
(17.29 KB, patch)
2014-12-10 21:47 PST
,
Beth Dakin
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2014-12-10 21:47:33 PST
Created
attachment 243099
[details]
Patch
mitz
Comment 2
2014-12-10 21:52:46 PST
Comment on
attachment 243099
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=243099&action=review
> Source/WebKit/mac/WebView/WebImmediateActionController.h:41 > +- (id)initWithWebView:(WebView *)webView;
The return type should be instancetype
> Source/WebKit/mac/WebView/WebImmediateActionController.mm:45 > +- (id)initWithWebView:(WebView *)webView
(and here to match)
Beth Dakin
Comment 3
2014-12-10 22:23:43 PST
Thank you, Dan!
http://trac.webkit.org/changeset/177131
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug