Bug 139521 - InstancedArray crashes attempting to draw out of bounds
Summary: InstancedArray crashes attempting to draw out of bounds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-10 18:41 PST by Dean Jackson
Modified: 2014-12-11 11:31 PST (History)
6 users (show)

See Also:

Attachments
Patch (67.91 KB, patch)
2014-12-10 18:52 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mountainlion (519.66 KB, application/zip)
2014-12-11 04:27 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-mountainlion-wk2 (518.51 KB, application/zip)
2014-12-11 04:30 PST, Build Bot 		no flags Details
Patch (68.82 KB, patch)
2014-12-11 10:42 PST, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-12-10 18:41:19 PST 
InstancedArray crashes attempting to draw out of bounds
Comment 1 Dean Jackson 2014-12-10 18:41:47 PST 
<rdar://problem/17540398>
Comment 2 Dean Jackson 2014-12-10 18:52:14 PST 
Created attachment 243088 [details]
Patch
Comment 3 Build Bot 2014-12-11 04:27:41 PST 
Comment on attachment 243088 [details]
Patch

Attachment 243088 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5385253694734336

New failing tests:
fast/canvas/webgl/angle-instanced-arrays-out-of-bounds.html
Comment 4 Build Bot 2014-12-11 04:27:43 PST 
Created attachment 243115 [details]
Archive of layout-test-results from ews100 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-12-11 04:30:13 PST 
Comment on attachment 243088 [details]
Patch

Attachment 243088 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5963765388410880

New failing tests:
fast/canvas/webgl/angle-instanced-arrays-out-of-bounds.html
Comment 6 Build Bot 2014-12-11 04:30:16 PST 
Created attachment 243116 [details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Dean Jackson 2014-12-11 10:42:40 PST 
Created attachment 243131 [details]
Patch
Comment 8 Simon Fraser (smfr) 2014-12-11 11:01:28 PST 
Comment on attachment 243131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243131&action=review

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2061
> +bool WebGLRenderingContext::validateDrawElements(const char* functionName, GC3Denum mode, GC3Dsizei count, GC3Denum type, long long offset, unsigned& numElements, GC3Dsizei primcount)

primitiveCount?
Comment 9 Dean Jackson 2014-12-11 11:31:14 PST 
Committed r177165: <http://trac.webkit.org/changeset/177165>