Bug 139511 - WK2: Add initial support for immediate actions
Summary: WK2: Add initial support for immediate actions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-10 15:32 PST by Beth Dakin
Modified: 2014-12-10 16:14 PST (History)
3 users (show)

See Also:

Attachments
Patch (27.35 KB, patch)
2014-12-10 15:49 PST, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-12-10 15:32:22 PST 
This bug tracks adding initial support for immediate actions
Comment 1 Beth Dakin 2014-12-10 15:49:22 PST 
Created attachment 243075 [details]
Patch
Comment 2 Tim Horton 2014-12-10 15:56:11 PST 
Comment on attachment 243075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243075&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3611
> +        NSImmediateActionGestureRecognizer *recognizer = [[NSImmediateActionGestureRecognizer alloc] initWithTarget:nil action:NULL];

How does ownership work here?

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:84
> +    if ([immediateActionRecognizer view] != _wkView)

dot notation

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:96
> +    if ([immediateActionRecognizer view] != _wkView)

dotto

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:117
> +    if ([immediateActionRecognizer view] != _wkView)

etc.
Comment 3 Beth Dakin 2014-12-10 16:14:19 PST 
Thanks Tim! We talked about the ownership stuff in person. http://trac.webkit.org/changeset/177113