Bug 139501 - Please disable the webkitFirstVersionWithInitConstructorSupport check on Apple TV
Summary: Please disable the webkitFirstVersionWithInitConstructorSupport check on Appl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-10 11:59 PST by Geoffrey Garen
Modified: 2015-04-27 16:55 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.67 KB, patch)
2014-12-10 12:56 PST, Geoffrey Garen 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2014-12-10 11:59:29 PST 
Please disable the webkitFirstVersionWithInitConstructorSupport check on ATV
Comment 1 Geoffrey Garen 2014-12-10 12:56:08 PST 
Created attachment 243059 [details]
Patch
Comment 2 Geoffrey Garen 2014-12-10 13:10:08 PST 
Committed r177091: <http://trac.webkit.org/changeset/177091>
Comment 3 Joseph Pecoraro 2015-04-27 16:55:02 PDT 
Comment on attachment 243059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243059&action=review

> Source/JavaScriptCore/API/JSWrapperMap.mm:664
> +#if PLATFORM(APPLETV)
> +    // There are no old clients on Apple TV, so there's no need for backwards compatibility.
> +    return true;
> +#endif
> +
>      static int32_t versionOfLinkTimeLibrary = 0;
>      if (!versionOfLinkTimeLibrary)
>          versionOfLinkTimeLibrary = NSVersionOfLinkTimeLibrary("JavaScriptCore");

I imagine that if we enabled unreachable code warnings it might complain about the unreachable code after the #if. Perhaps an #if/#else/#endif might be better.