Bug 139487 – [GStreamer] Use a buffer pool for the allocations in AudioDestination

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Sebastian Dröge (slomo)]

Patch coming in a few seconds.

[Sebastian Dröge (slomo)]

Created attachment 243026 [details]
Patch

[Build Bot]

Comment on attachment 243026 [details]
Patch

Attachment 243026 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4519363323363328

New failing tests:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html

[Build Bot]

Created attachment 243031 [details]
Archive of layout-test-results from ews107 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Philippe Normand]

Comment on attachment 243026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243026&action=review

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:339
> +        GstFlowReturn flow_ret = gst_buffer_pool_acquire_buffer(priv->pool, &channelBuffer, nullptr);
> +
> +        if (flow_ret != GST_FLOW_OK) {

Here you could avoid the flow_ret local variable. BTW we prefer camelCase naming :p

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:349
> +            gst_task_pause(src->priv->task.get());
> +            return;

Would be nice to emit an error message here but that's for another patch :)

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:446
> +        config = gst_buffer_pool_get_config(src->priv->pool);

We try as much as possible to declare and assign variables in the same line. Here it could be done easily.

[Sebastian Dröge (slomo)]

Created attachment 243036 [details]
Patch

[Philippe Normand]

Comment on attachment 243036 [details]
Patch

LGTM!

[Build Bot]

Comment on attachment 243036 [details]
Patch

Attachment 243036 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5787313904812032

New failing tests:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html

[Build Bot]

Created attachment 243041 [details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Philippe Normand]

Comment on attachment 243036 [details]
Patch

Clearing flags on attachment: 243036

Committed r177079: <http://trac.webkit.org/changeset/177079>

[Philippe Normand]

All reviewed patches have been landed.  Closing bug.