Bug 139476 - Floats Don't Overhang Their Block Formatting Contex
Summary: Floats Don't Overhang Their Block Formatting Contex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-10 03:50 PST by Javier Fernandez
Modified: 2014-12-15 13:06 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.52 KB, patch)
2014-12-10 04:14 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2014-12-10 03:50:40 PST 
Floats Don't Overhang Their Block Formatting Context Per http://www.w3.org/TR/CSS2/visuren.html#float-position: "References to [the elements] in the [rules that govern the behaviour of floats] refer only to other elements in the same block formatting context as the float."

This means we don't need to look for intruding or overhanging floats in boxes that establish a new block formatting context. I couldn't find a test where we failed this rule but we do appear to be doing unnecessary work in rebuildFloatsFromIntruding() so make sure we avoid adding floats from different block formatting contexts.
Comment 1 Javier Fernandez 2014-12-10 04:14:40 PST 
Created attachment 243007 [details]
Patch
Comment 2 Dave Hyatt 2014-12-15 12:26:35 PST 
Comment on attachment 243007 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-12-15 13:06:46 PST 
Comment on attachment 243007 [details]
Patch

Clearing flags on attachment: 243007

Committed r177308: <http://trac.webkit.org/changeset/177308>
Comment 4 WebKit Commit Bot 2014-12-15 13:06:50 PST 
All reviewed patches have been landed.  Closing bug.