Bug 139470 - Streamline and refactor font-related classes
Summary: Streamline and refactor font-related classes
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-09 20:10 PST by Darin Adler
Modified: 2015-03-28 17:09 PDT (History)
2 users (show)

See Also:

Attachments
first cut (221.90 KB, patch)
2014-12-10 09:02 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
second try (228.89 KB, patch)
2014-12-10 10:07 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
another try (235.68 KB, patch)
2014-12-10 10:25 PST, Darin Adler 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-mountainlion (925.49 KB, application/zip)
2014-12-10 11:08 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (859.47 KB, application/zip)
2014-12-10 11:57 PST, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-12-09 20:10:57 PST 
Streamline and refactor font-related classes
Comment 1 Darin Adler 2014-12-10 09:02:04 PST 
Created attachment 243028 [details]
first cut
Comment 2 Darin Adler 2014-12-10 10:07:41 PST 
Created attachment 243040 [details]
second try
Comment 3 Darin Adler 2014-12-10 10:08:01 PST 
Patch got too big; I’ll have to break it down into pieces again. Ugh.
Comment 4 Darin Adler 2014-12-10 10:25:56 PST 
Created attachment 243046 [details]
another try
Comment 5 Build Bot 2014-12-10 11:08:05 PST 
Comment on attachment 243046 [details]
another try

Attachment 243046 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6477442671706112

New failing tests:
fast/forms/text-control-intrinsic-widths.html
svg/custom/altglyph.svg
svg/text/multichar-glyph.svg
Comment 6 Build Bot 2014-12-10 11:08:08 PST 
Created attachment 243050 [details]
Archive of layout-test-results from ews101 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-12-10 11:57:35 PST 
Comment on attachment 243046 [details]
another try

Attachment 243046 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5052636663382016

New failing tests:
fast/forms/text-control-intrinsic-widths.html
svg/custom/altglyph.svg
svg/text/multichar-glyph.svg
Comment 8 Build Bot 2014-12-10 11:57:37 PST 
Created attachment 243055 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Darin Adler 2015-03-28 17:09:58 PDT 
Antti made lots of changes to font code; not sure any of this applies any more.