Bug 13947 - Finish autogenerating the JS DOM traversal code
Summary: Finish autogenerating the JS DOM traversal code
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 13779
  Show dependency treegraph
Reported: 2007-05-30 23:24 PDT by Sam Weinig
Modified: 2007-06-06 18:55 PDT (History)
0 users

See Also:

patch (45.95 KB, patch)
2007-05-30 23:34 PDT, Sam Weinig
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2007-05-30 23:24:08 PDT
Patch on its way.
Comment 1 Sam Weinig 2007-05-30 23:34:07 PDT
Created attachment 14798 [details]

I am a little uneasy about this patch and wouldn't mind some harsh reviewing of it.  The part I am uneasy about is the changing of the NodeFilter parameter of Document::createNodeIterator and Document::createTreeWalker to be regular pointers instead of PassRefPtrs.  I did this becuase it makes generating a lot easier and that is how parameters are generally passed for the bindings.  If there is any slowdown or other issues that this might cause I am sure I can come up with a work around in the bindings scripts, but I thought I would check if this way was OK first.
Comment 2 Dave Hyatt 2007-06-06 16:55:46 PDT
Comment on attachment 14798 [details]

Comment 3 Sam Weinig 2007-06-06 18:55:17 PDT
Landed in r22035.