Bug 139469 - Simple line layout: Add 16bit support.
Summary: Simple line layout: Add 16bit support.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-09 19:16 PST by zalan
Modified: 2014-12-12 03:49 PST (History)
6 users (show)

See Also:

Attachments
Patch (11.35 KB, patch)
2014-12-10 16:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.48 KB, patch)
2014-12-11 12:40 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-12-09 19:16:55 PST 
16bit support was temporarily removed at bug 138796.
Comment 1 zalan 2014-12-10 16:12:27 PST 
Created attachment 243077 [details]
Patch
Comment 2 zalan 2014-12-10 20:40:02 PST 
rdar://problem/19210121
Comment 3 Antti Koivisto 2014-12-11 08:37:08 PST 
Comment on attachment 243077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243077&action=review

r=me

> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:84
> +    template <typename CharacterType>
>      float runWidth(const String&, unsigned from, unsigned to, float xPosition) const;

could put this on the same line
Comment 4 Myles C. Maxfield 2014-12-11 12:04:03 PST 
Comment on attachment 243077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243077&action=review

> Source/WebCore/rendering/SimpleLineLayoutFlowContents.cpp:137
> +            runWidth<UChar>(segment->text, from - segment->start, fragmentEnd - segment->start, xPosition + textWidth);

Yuck.
Comment 5 zalan 2014-12-11 12:40:48 PST 
Created attachment 243139 [details]
Patch
Comment 6 WebKit Commit Bot 2014-12-12 03:49:17 PST 
Comment on attachment 243139 [details]
Patch

Clearing flags on attachment: 243139

Committed r177219: <http://trac.webkit.org/changeset/177219>
Comment 7 WebKit Commit Bot 2014-12-12 03:49:22 PST 
All reviewed patches have been landed.  Closing bug.