Bug 139461 - Remove DataCue "text" attribute
Summary: Remove DataCue "text" attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brendan Long
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-09 14:55 PST by Brendan Long
Modified: 2014-12-11 16:17 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.32 KB, patch)
2014-12-10 15:12 PST, Brendan Long 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-mountainlion-wk2 (601.51 KB, application/zip)
2014-12-10 15:35 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2014-12-09 14:55:48 PST 
It looks like W3C has removed the "text" attribute from DataCue:

http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#datacue

Safari uses a different iterface, so this change will probably only effect WebKitGTK and other GStreamer-based ports.
Comment 1 Brendan Long 2014-12-10 15:12:30 PST 
Created attachment 243071 [details]
Patch
Comment 2 Build Bot 2014-12-10 15:35:24 PST 
Comment on attachment 243071 [details]
Patch

Attachment 243071 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5621714461392896

New failing tests:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
Comment 3 Build Bot 2014-12-10 15:35:27 PST 
Created attachment 243073 [details]
Archive of layout-test-results from ews107 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Brendan Long 2014-12-11 15:38:03 PST 
Comment on attachment 243071 [details]
Patch

I assume these test failures are meaningless, since they didn't pass before my patch, and they have absolutely nothing to do with text tracks.
Comment 5 WebKit Commit Bot 2014-12-11 16:17:35 PST 
Comment on attachment 243071 [details]
Patch

Clearing flags on attachment: 243071

Committed r177190: <http://trac.webkit.org/changeset/177190>
Comment 6 WebKit Commit Bot 2014-12-11 16:17:40 PST 
All reviewed patches have been landed.  Closing bug.