Bug 139460 – Provide SPI to asynchronously move a WKView into a window and know when it has painted

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Provide SPI to asynchronously move a WKView into a window and know when it has painted

[Tim Horton]

Created attachment 242967 [details]
Patch

[Tim Horton]

<rdar://problem/19135389>

[WebKit Commit Bot]

Attachment 242967 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2830:  The parameter name "window" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 242967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242967&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2530
> +    // If we're in the middle of preparing to move to a window, ignore actual moves.
> +    if (_data->_targetWindowForMovePreparation && window != _data->_targetWindowForMovePreparation)
> +        return;

Is this even allowed? :|

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1172
> +{

space after void.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1178
> +    void(^copiedCompletionHandler)() = Block_copy(completionHandler);

auto.

[Tim Horton]

http://trac.webkit.org/changeset/177104

[Tim Horton]

Build fix in http://trac.webkit.org/changeset/177106

[Carlos Alberto Lopez Perez]

(In reply to comment #5)
> http://trac.webkit.org/changeset/177104

(In reply to comment #6)
> Build fix in http://trac.webkit.org/changeset/177106

Both the GTK and EFL release build are broken by this :(

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29?numbuilds=50

https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Thumb2%20Release%20%28Build%29?numbuilds=50

[Csaba Osztrogonác]

buildfix landed in https://trac.webkit.org/changeset/177123