Bug 139456 – Import Mozilla test suite for SVG

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Said Abou-Hallawa]

A part of the Mozilla test suite for SVG will be ported for WebKit. 

The failures are already reported in WebKit Bugzilla. The failed tests will be excluded in the LayoutTests/TestExpectations file.

The rest of the tests will be submitted later as they are investigated and the failures are reduced to a specific non-complinance or incompleteness problem with WebKit SVG implementation.

[Radar WebKit Bug Importer]

<rdar://problem/19194627>

[Said Abou-Hallawa]

Created attachment 242959 [details]
Patch

[Build Bot]

Comment on attachment 242959 [details]
Patch

Attachment 242959 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6122705216602112

New failing tests:
imported/mozilla/svg/stroke-dasharray-01.svg

[Build Bot]

Created attachment 242963 [details]
Archive of layout-test-results from ews101 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 242959 [details]
Patch

Attachment 242959 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5939749273468928

New failing tests:
svg/animations/unsupported-animate-element-attributes.svg
imported/mozilla/svg/dynamic-conditions-07.svg
imported/mozilla/svg/dynamic-filter-contents-01b.svg
imported/mozilla/svg/stroke-dasharray-01.svg

[Build Bot]

Created attachment 242966 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Said Abou-Hallawa]

Created attachment 242971 [details]
Patch

[Said Abou-Hallawa]

Delete flaky tests for now.

[Build Bot]

Comment on attachment 242971 [details]
Patch

Attachment 242971 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5597383471661056

New failing tests:
imported/mozilla/svg/dynamic-conditions-11.svg

[Build Bot]

Created attachment 242977 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Said Abou-Hallawa]

Created attachment 242979 [details]
Patch

[Said Abou-Hallawa]

Delete one more flaky test fails only on mac-wk2.

[Dean Jackson]

Comment on attachment 242979 [details]
Patch

rs=me

[Dean Jackson]

Not sure why EFL is failing.

[WebKit Commit Bot]

Comment on attachment 242979 [details]
Patch

Rejecting attachment 242979 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 242979, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
lla/svg/text/textpath-multiline-expected.svg
patching file LayoutTests/imported/mozilla/svg/text/textpath-multiline.svg
patching file LayoutTests/imported/mozilla/svg/text/textpath-selection-expected.svg
patching file LayoutTests/imported/mozilla/svg/text/textpath-selection.svg
patching file LayoutTests/imported/mozilla/svg/text/textpath.svg

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5037272223186944

[Said Abou-Hallawa]

Created attachment 243297 [details]
Patch

[Said Abou-Hallawa]

Created attachment 243298 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 243298 [details]
Patch

Rejecting attachment 243298 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Said Abou-Hallawa]

Comment on attachment 243298 [details]
Patch

In http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json, my account [e-mail] is listed as a committer.  So let me try one more time to cq+ this bug.

[WebKit Commit Bot]

Comment on attachment 243298 [details]
Patch

Rejecting attachment 243298 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Said Abou-Hallawa]

Comment on attachment 243298 [details]
Patch

I am hoping the updated contributors.json is now propagated into Bot and this will allow me to cq+ this bug.

[WebKit Commit Bot]

Comment on attachment 243298 [details]
Patch

Rejecting attachment 243298 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Said Abou-Hallawa]

Comment on attachment 243298 [details]
Patch

cq+ for this patch since it has been more than two hours since the Contributors.json was updated.

[WebKit Commit Bot]

Comment on attachment 243298 [details]
Patch

Rejecting attachment 243298 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 243298, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/imported/mozilla/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/4659398853001216

[Said Abou-Hallawa]

Created attachment 243325 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 243325 [details]
Patch

Clearing flags on attachment: 243325

Committed r177330: <http://trac.webkit.org/changeset/177330>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.