Bug 139456 - Import Mozilla test suite for SVG
Summary: Import Mozilla test suite for SVG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 140254
  Show dependency treegraph
 
Reported: 2014-12-09 12:07 PST by Said Abou-Hallawa
Modified: 2015-01-08 10:20 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.44 MB, patch)
2014-12-09 13:19 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-mountainlion (627.69 KB, application/zip)
2014-12-09 14:12 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (547.75 KB, application/zip)
2014-12-09 14:35 PST, Build Bot
no flags Details
Patch (1.43 MB, patch)
2014-12-09 15:35 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (514.51 KB, application/zip)
2014-12-09 16:59 PST, Build Bot
no flags Details
Patch (1.43 MB, patch)
2014-12-09 17:09 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (1.43 MB, patch)
2014-12-15 10:06 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (1.43 MB, patch)
2014-12-15 10:09 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (1.43 MB, patch)
2014-12-15 16:01 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2014-12-09 12:07:12 PST
A part of the Mozilla test suite for SVG will be ported for WebKit. 

The failures are already reported in WebKit Bugzilla. The failed tests will be excluded in the LayoutTests/TestExpectations file.

The rest of the tests will be submitted later as they are investigated and the failures are reduced to a specific non-complinance or incompleteness problem with WebKit SVG implementation.
Comment 1 Radar WebKit Bug Importer 2014-12-09 13:02:10 PST
<rdar://problem/19194627>
Comment 2 Said Abou-Hallawa 2014-12-09 13:19:26 PST
Created attachment 242959 [details]
Patch
Comment 3 Build Bot 2014-12-09 14:12:21 PST
Comment on attachment 242959 [details]
Patch

Attachment 242959 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6122705216602112

New failing tests:
imported/mozilla/svg/stroke-dasharray-01.svg
Comment 4 Build Bot 2014-12-09 14:12:24 PST
Created attachment 242963 [details]
Archive of layout-test-results from ews101 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-12-09 14:35:06 PST
Comment on attachment 242959 [details]
Patch

Attachment 242959 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5939749273468928

New failing tests:
svg/animations/unsupported-animate-element-attributes.svg
imported/mozilla/svg/dynamic-conditions-07.svg
imported/mozilla/svg/dynamic-filter-contents-01b.svg
imported/mozilla/svg/stroke-dasharray-01.svg
Comment 6 Build Bot 2014-12-09 14:35:09 PST
Created attachment 242966 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Said Abou-Hallawa 2014-12-09 15:35:21 PST
Created attachment 242971 [details]
Patch
Comment 8 Said Abou-Hallawa 2014-12-09 15:36:37 PST
Delete flaky tests for now.
Comment 9 Build Bot 2014-12-09 16:59:28 PST
Comment on attachment 242971 [details]
Patch

Attachment 242971 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5597383471661056

New failing tests:
imported/mozilla/svg/dynamic-conditions-11.svg
Comment 10 Build Bot 2014-12-09 16:59:33 PST
Created attachment 242977 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 11 Said Abou-Hallawa 2014-12-09 17:09:37 PST
Created attachment 242979 [details]
Patch
Comment 12 Said Abou-Hallawa 2014-12-09 17:10:35 PST
Delete one more flaky test fails only on mac-wk2.
Comment 13 Dean Jackson 2014-12-11 15:49:11 PST
Comment on attachment 242979 [details]
Patch

rs=me
Comment 14 Dean Jackson 2014-12-11 15:50:08 PST
Not sure why EFL is failing.
Comment 15 WebKit Commit Bot 2014-12-11 16:13:20 PST
Comment on attachment 242979 [details]
Patch

Rejecting attachment 242979 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 242979, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
lla/svg/text/textpath-multiline-expected.svg
patching file LayoutTests/imported/mozilla/svg/text/textpath-multiline.svg
patching file LayoutTests/imported/mozilla/svg/text/textpath-selection-expected.svg
patching file LayoutTests/imported/mozilla/svg/text/textpath-selection.svg
patching file LayoutTests/imported/mozilla/svg/text/textpath.svg

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5037272223186944
Comment 16 Said Abou-Hallawa 2014-12-15 10:06:03 PST
Created attachment 243297 [details]
Patch
Comment 17 Said Abou-Hallawa 2014-12-15 10:09:55 PST
Created attachment 243298 [details]
Patch
Comment 18 WebKit Commit Bot 2014-12-15 13:32:03 PST
Comment on attachment 243298 [details]
Patch

Rejecting attachment 243298 [details] from commit-queue.

sabouhallawa@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 19 Said Abou-Hallawa 2014-12-15 13:37:19 PST
Comment on attachment 243298 [details]
Patch

In http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json, my account sabouhallawa@apple.com is listed as a committer.  So let me try one more time to cq+ this bug.
Comment 20 WebKit Commit Bot 2014-12-15 13:37:57 PST
Comment on attachment 243298 [details]
Patch

Rejecting attachment 243298 [details] from commit-queue.

sabouhallawa@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 21 Said Abou-Hallawa 2014-12-15 14:10:10 PST
Comment on attachment 243298 [details]
Patch

I am hoping the updated contributors.json is now propagated into Bot and this will allow me to cq+ this bug.
Comment 22 WebKit Commit Bot 2014-12-15 14:10:48 PST
Comment on attachment 243298 [details]
Patch

Rejecting attachment 243298 [details] from commit-queue.

sabouhallawa@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 23 Said Abou-Hallawa 2014-12-15 15:36:58 PST
Comment on attachment 243298 [details]
Patch

cq+ for this patch since it has been more than two hours since the Contributors.json was updated.
Comment 24 WebKit Commit Bot 2014-12-15 15:50:41 PST
Comment on attachment 243298 [details]
Patch

Rejecting attachment 243298 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 243298, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/imported/mozilla/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/4659398853001216
Comment 25 Said Abou-Hallawa 2014-12-15 16:01:10 PST
Created attachment 243325 [details]
Patch
Comment 26 WebKit Commit Bot 2014-12-15 18:19:35 PST
Comment on attachment 243325 [details]
Patch

Clearing flags on attachment: 243325

Committed r177330: <http://trac.webkit.org/changeset/177330>
Comment 27 WebKit Commit Bot 2014-12-15 18:19:40 PST
All reviewed patches have been landed.  Closing bug.