Bug 139455 - Implement clearing of cookies
Summary: Implement clearing of cookies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-09 11:29 PST by Anders Carlsson
Modified: 2014-12-09 16:13 PST (History)
3 users (show)

See Also:

Attachments
Patch (22.28 KB, patch)
2014-12-09 11:36 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-12-09 11:29:35 PST 
Implement clearing of cookies
Comment 1 Anders Carlsson 2014-12-09 11:36:45 PST 
Created attachment 242950 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-09 11:39:56 PST 
Attachment 242950 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:102:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:140:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:118:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:56:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 7 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-12-09 12:15:22 PST 
Comment on attachment 242950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242950&action=review

r=me

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:246
> +    parentProcessConnection()->send(Messages::NetworkProcessProxy::DidDeleteWebsiteData(callbackID), 0);

Can we make parentProcessConnection() return a reference?

> Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:94
> +enum class ProcessAccessType {
> +    None,
> +    OnlyIfLaunched,
> +    Launch,
> +};

This is very nifty.
Comment 4 Anders Carlsson 2014-12-09 12:29:33 PST 
Committed r177032: <http://trac.webkit.org/changeset/177032>
Comment 5 Csaba Osztrogonác 2014-12-09 16:13:24 PST 
and the buildfix landed in https://trac.webkit.org/changeset/177043