Bug 139434 – [CMAKE] bump GSTREAMER required version to 1.2.0

• Status: RESOLVED
• Resolution: INVALID
• Component: Media

[Fabien Vallée]

Cmake is defined required version for gstreamer as "1.0.3" but it cannot compile anymore.

Following commit: "[GStreamer] HTTP source element lacks SCHEDULING query support" http://trac.webkit.org/changeset/17656
is introducing "GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED" flags which is defined only in gstreamer >= 1.2.0
(https://developer.gnome.org/gstreamer/stable/gstreamer-GstQuery.html#GstSchedulingFlags)

Jhbuild is using 
gtk: gstreamer 1.4.4 (https://bugs.webkit.org/show_bug.cgi?id=138866)
efl: gstreamer1.2.1  (https://bugs.webkit.org/show_bug.cgi?id=125155)

so it should be safe to set 1.2.0 required in cmake.

[Fabien Vallée]

Created attachment 242897 [details]
Patch

[Fabien Vallée]

there is a typo in my previous comment, 
correct link to gstreamer patch introducing GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED is :

"[GStreamer] HTTP source element lacks SCHEDULING query support" http://trac.webkit.org/changeset/176561

[Martin Robinson]

Comment on attachment 242897 [details]
Patch

We cannot bump the required version of GStreamer for WebKitGTK+, but we can use conditional compilation to enable features when compiling against a newer version.

[Philippe Normand]

Right, it was my mistake, the SCHEDULING query code should be guarded with a ifdef.

[Fabien Vallée]

ok, use compile guards is indeed a very good solution ;)