Bug 139431 – Unskip more multipart tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

http/tests/multipart/invalid-image-data-standalone.html uses resources/multipart.php, which was fixed today. It seems like a fairly weak test, and it mostly duplicates http/tests/multipart/multipart-image.html, but given how poor multipart test coverage is, it may be worth enabling if we can.

http/tests/multipart/load-last-non-html-frame.php has the same bug as resources/multipart.php had, which can be simply fixed.

[Alexey Proskuryakov]

Created attachment 242887 [details]
proposed patch

I only tested on Yosemite, let's see what EWS thinks.

[Build Bot]

Comment on attachment 242887 [details]
proposed patch

Attachment 242887 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4980705087979520

New failing tests:
http/tests/multipart/invalid-image-data-standalone.html

[Build Bot]

Created attachment 242890 [details]
Archive of layout-test-results from ews102 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 242887 [details]
proposed patch

Attachment 242887 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5239392578830336

New failing tests:
http/tests/multipart/invalid-image-data-standalone.html

[Build Bot]

Created attachment 242895 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Alexey Proskuryakov]

Created attachment 242984 [details]
proposed patch

OK, let's unskip it on Mavericks only, where it passed for me. It may be the same issue I observed with http/tests/multipart/multipart-image.html, where we were two frames behind instead of one frame behind.

[Darin Adler]

Comment on attachment 242984 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242984&action=review

> LayoutTests/ChangeLog:8
> +        * http/tests/multipart/load-last-non-html-frame.php:

No explanation of the change?

[WebKit Commit Bot]

Comment on attachment 242984 [details]
proposed patch

Clearing flags on attachment: 242984

Committed r177054: <http://trac.webkit.org/changeset/177054>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.