Bug 139428 - Fix EFL build fix since r177001
Summary: Fix EFL build fix since r177001
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 139416
Blocks:
  Show dependency tree / graph
 
Reported: 2014-12-08 21:40 PST by Gyuyoung Kim
Modified: 2014-12-08 21:52 PST (History)
0 users

See Also:

Attachments
Patch (1.35 KB, patch)
2014-12-08 21:42 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-12-08 21:40:18 PST 
EFL port has broken since r177001. Because EFL port treats build warning as error. This patch generated a below warning.

../../Source/JavaScriptCore/parser/Nodes.h:1104:11: error: direct base ‘JSC::ParserArenaFreeable’ inaccessible in ‘JSC::CommaNode’ due to ambiguity [-Werror]
     class CommaNode final : public ExpressionNode, public ParserArenaFreeable {
Comment 1 Gyuyoung Kim 2014-12-08 21:42:40 PST 
Created attachment 242881 [details]
Patch
Comment 2 Mark Lam 2014-12-08 21:48:43 PST 
Comment on attachment 242881 [details]
Patch

r=me
Comment 3 Gyuyoung Kim 2014-12-08 21:52:28 PST 
Comment on attachment 242881 [details]
Patch

Clearing flags on attachment: 242881

Committed r177010: <http://trac.webkit.org/changeset/177010>
Comment 4 Gyuyoung Kim 2014-12-08 21:52:35 PST 
All reviewed patches have been landed.  Closing bug.