Bug 139420 - Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow()
Summary: Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-08 15:52 PST by Chris Dumez
Modified: 2014-12-08 17:28 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2014-12-08 16:03 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-12-08 15:52:12 PST 
Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow(). This has no behavior change as changeRequiresLayout() calls changeAffectsVisualOverflow(). However, this is clearer as text-shadow affects the visual overflow (similarly to box-shadow).
Comment 1 Chris Dumez 2014-12-08 16:03:21 PST 
Created attachment 242859 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-08 17:27:54 PST 
Comment on attachment 242859 [details]
Patch

Clearing flags on attachment: 242859

Committed r176998: <http://trac.webkit.org/changeset/176998>
Comment 3 WebKit Commit Bot 2014-12-08 17:28:01 PST 
All reviewed patches have been landed.  Closing bug.