Bug 139401 - Remove ResourceHandle::loadsBlocked()
Summary: Remove ResourceHandle::loadsBlocked()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-08 08:42 PST by Anders Carlsson
Modified: 2014-12-08 08:57 PST (History)
0 users

See Also:


Attachments
Patch (5.31 KB, patch)
2014-12-08 08:44 PST, Anders Carlsson
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-12-08 08:42:56 PST
Remove ResourceHandle::loadsBlocked()
Comment 1 Anders Carlsson 2014-12-08 08:44:04 PST
Created attachment 242814 [details]
Patch
Comment 2 Daniel Bates 2014-12-08 08:56:35 PST
Comment on attachment 242814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242814&action=review

> Source/WebCore/page/Chrome.cpp:230
>      // If loads are blocked, we can't run modal because the contents
>      // of the modal dialog will never show up!

Is this comment still relevant? Notice that it was added when we added the conjunct "!ResourceHandle::loadsBlocked()" in <http://trac.webkit.org/changeset/17577>.
Comment 3 Anders Carlsson 2014-12-08 08:57:07 PST
Committed r176949: <http://trac.webkit.org/changeset/176949>