WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 139401
Remove ResourceHandle::loadsBlocked()
https://bugs.webkit.org/show_bug.cgi?id=139401
Summary
Remove ResourceHandle::loadsBlocked()
Anders Carlsson
Reported
2014-12-08 08:42:56 PST
Remove ResourceHandle::loadsBlocked()
Attachments
Patch
(5.31 KB, patch)
2014-12-08 08:44 PST
,
Anders Carlsson
dbates
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-12-08 08:44:04 PST
Created
attachment 242814
[details]
Patch
Daniel Bates
Comment 2
2014-12-08 08:56:35 PST
Comment on
attachment 242814
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=242814&action=review
> Source/WebCore/page/Chrome.cpp:230 > // If loads are blocked, we can't run modal because the contents > // of the modal dialog will never show up!
Is this comment still relevant? Notice that it was added when we added the conjunct "!ResourceHandle::loadsBlocked()" in <
http://trac.webkit.org/changeset/17577
>.
Anders Carlsson
Comment 3
2014-12-08 08:57:07 PST
Committed
r176949
: <
http://trac.webkit.org/changeset/176949
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug