Bug 139360 - [GStreamer] Use audio-filter property for pitch-preserving element
Summary: [GStreamer] Use audio-filter property for pitch-preserving element
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Sebastian Dröge (slomo)
Depends on:
Reported: 2014-12-07 04:28 PST by Sebastian Dröge (slomo)
Modified: 2014-12-08 01:22 PST (History)
1 user (show)

See Also:

Patch (2.95 KB, patch)
2014-12-07 04:30 PST, Sebastian Dröge (slomo)
no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2014-12-07 10:41 PST, Sebastian Dröge (slomo)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Dröge (slomo) 2014-12-07 04:28:42 PST
Patch coming in a second. Together with my next change this allows us to use playbin's special sink selection mechanisms, which will allow us to automatically use sinks that handle compressed input if possible. But even alone it makes the code a bit simpler (once we can depend on >= 1.4.2).
Comment 1 Sebastian Dröge (slomo) 2014-12-07 04:30:48 PST
Created attachment 242739 [details]
Comment 2 Gustavo Noronha (kov) 2014-12-07 10:08:44 PST
Comment on attachment 242739 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=242739&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1834
> +    // On 1.4.2 and newer we use the audio-filter property instead

Nit: missing full stop.
Comment 3 Sebastian Dröge (slomo) 2014-12-07 10:41:42 PST
Created attachment 242757 [details]
Comment 4 WebKit Commit Bot 2014-12-08 01:22:56 PST
Comment on attachment 242757 [details]

Clearing flags on attachment: 242757

Committed r176939: <http://trac.webkit.org/changeset/176939>
Comment 5 WebKit Commit Bot 2014-12-08 01:22:59 PST
All reviewed patches have been landed.  Closing bug.