Bug 139350 – Stop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy()

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

Stop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy() and use m_loadType instead. ResourceRequest::cachePolicy() is meant to be passed to the network stack, and isn't supposed to be used as input inside WebCore [1].

[1] https://bugs.webkit.org/show_bug.cgi?id=139263#c2

[Chris Dumez]

Created attachment 242732 [details]
Patch

[Antti Koivisto]

Comment on attachment 242732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242732&action=review

> Source/WebCore/loader/FrameLoader.cpp:2160
> +    default:
> +        return CachePolicyVerify;
> +    }

It would be better to list all cases rather than use default.

[Chris Dumez]

Created attachment 242823 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 242823 [details]
Patch

Clearing flags on attachment: 242823

Committed r176953: <http://trac.webkit.org/changeset/176953>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #4)
> Comment on attachment 242823 [details]
> Patch
> 
> Clearing flags on attachment: 242823
> 
> Committed r176953: <http://trac.webkit.org/changeset/176953>

It broke the EFL build, because gcc need some love - an unreachable return.
I'm wondering why EFL EWS didn't notice this warning ...

../../Source/WebCore/loader/FrameLoader.cpp: In member function ‘WebCore::CachePolicy WebCore::FrameLoader::subresourceCachePolicy() const’:
../../Source/WebCore/loader/FrameLoader.cpp:2167:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Fix is coming.

[Csaba Osztrogonác]

Fix landed in https://trac.webkit.org/changeset/176958