JSC now has control flow profiler functionality. Create an inspector API for this feature.
<rdar://problem/19168297>
Created attachment 242725 [details] patch
Comment on attachment 242725 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=242725&action=review > Source/JavaScriptCore/inspector/protocol/Runtime.json:160 > + "id": "BasicBlockLocation", > + "type": "object", > + "description": "Describes the location of a basic block and if that basic block has executed.", What exactly is a "Basic Block"? That sounds like a JSC specific name, but is there a more generic name we could use here? Is there a language agnostic term for what a basic block is? It sounds like this could just be a Type named "Basic Block" with a startOffset, endOffset, and hasExecuted. I don't think a "hasExecuted" property makes sense inside an object named "FooLocation".
Comment on attachment 242725 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=242725&action=review > Source/JavaScriptCore/ChangeLog:9 > + to get information about which basic blocks have exectued typo: executed >> Source/JavaScriptCore/inspector/protocol/Runtime.json:160 >> + "description": "Describes the location of a basic block and if that basic block has executed.", > > What exactly is a "Basic Block"? That sounds like a JSC specific name, but is there a more generic name we could use here? Is there a language agnostic term for what a basic block is? > > It sounds like this could just be a Type named "Basic Block" with a startOffset, endOffset, and hasExecuted. I don't think a "hasExecuted" property makes sense inside an object named "FooLocation". (Almost) every compiler uses the term 'basic block'. A different name would be very confusing.
> What exactly is a "Basic Block"? That sounds like a JSC specific name, but > is there a more generic name we could use here? Is there a language agnostic > term for what a basic block is? Saam set me straight. This is the ideal name: http://en.wikipedia.org/wiki/Basic_block
Created attachment 242868 [details] patch Made the recommended name changes.
Created attachment 242869 [details] patch (Same as above but w/ const variable that can be const).
Comment on attachment 242869 [details] patch Clearing flags on attachment: 242869 Committed r177008: <http://trac.webkit.org/changeset/177008>
All reviewed patches have been landed. Closing bug.